Skip to content

fix/perf: Do not prefetch the header Changelog link #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marcleblanc2 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Draft

fix/perf: Do not prefetch the header Changelog link #2002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,18 @@ function Header() {
<Search />
</div>
<div className="relative flex basis-0 items-center justify-end gap-6 sm:gap-6 md:flex-grow">
<Link
{/* Plain anchor: next/link treats this same-origin URL as an
app route and prefetches the changelog app's ~60 assets on
every docs page. */}
<a
href="https://sourcegraph.com/changelog"
className="hidden whitespace-nowrap rounded-md text-xs font-medium text-slate-500 hover:text-vermilion-11 focus:outline-none focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-vermilion-11/50 dark:text-dark-paragraph-text dark:hover:text-vermilion-11 lg:inline-flex"
>
Changelog
<span className="ml-1" aria-hidden="true">
↗
</span>
</Link>
</a>
<VersionSelector />
<ThemeSelector className="relative z-10" />
<Link
Expand Down
5 changes: 3 additions & 2 deletions src/components/MobileNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,16 @@ export function MobileNavigation() {
/>
</Link>
</div>
<Link
{/* Plain anchor, so next/link does not prefetch the changelog app */}
<a
href="https://sourcegraph.com/changelog"
className="mt-5 inline-flex rounded-md px-1 text-base font-medium text-slate-500 hover:text-vermilion-11 focus:outline-none focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-vermilion-11/50 dark:text-dark-text-secondary dark:hover:text-vermilion-11"
>
Changelog
<span className="ml-1" aria-hidden="true">
↗
</span>
</Link>
</a>
<Suspense fallback={null}>
<Navigation
className="mt-5 px-1"
Expand Down
Loading