Repository navigation
chore(release): drop setup-node registry-url, not needed for trusted publishing - #514
Merged
Merged
Conversation
…publishing Amp-Thread-ID: https://ampcode.com/threads/T-01a15d8e-18fa-77e7-a024-70a168eb5f7e Co-authored-by: Amp <amp@ampcode.com>
keegancsmith
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow has failed in
actions/setup-nodeon every run since #511:With
registry-urlset, setup-node writes an.npmrccontaining_authToken=${NODE_AUTH_TOKEN}and then runsyarn cache dirfor caching. Yarn 1 throws when that variable is undefined. Before #511 it was defined, as an empty string, viasecrets.NPM_TOKEN.Trusted publishing doesn't need the
.npmrc: npm's OIDC flow only uses GitHub'sACTIONS_ID_TOKEN_REQUEST_*env vars and the default registry (registry.npmjs.org), so this dropsregistry-url.Test plan
Reproduced locally with yarn 1.22.22:
yarn cache dirfails with the same error when the setup-node style.npmrcis present andNODE_AUTH_TOKENis unset, and succeeds without that.npmrc. The main-branch release run after merging confirms setup-node passes; the npm publish itself is exercised by the v0.5.1 tag.