Repository navigation
Reject empty metadata keys in MCP validation - #3023
Open
HarshPopat23 wants to merge 1 commit into
Open
HarshPopat23 wants to merge 1 commit into
HarshPopat23 wants to merge 1 commit into
Conversation
MCP metadata keys without a prefix must begin and end with an alphanumeric character. Previously, metadata_key allowed an empty string when prefix_required was false because name.empty() evaluated to true. Hold unprefixed keys to having at least one valid character, rejecting empty keys. Signed-off-by: HarshPopat23 <musichk61@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Re-trigger cubic
🤖 Augment PR SummaryRejects empty metadata keys to enforce MCP 2026-07-28 naming rules. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold unprefixed MCP metadata keys to having at least one valid character, rejecting empty keys.
Under MCP 2026-07-28, keys without a prefix must begin and end with an alphanumeric character. Previously, metadata_key permitted an empty string when prefix_required was false because name.empty() evaluated to true.
Add regressions across request meta, notification, and result writer validation.