Skip to content

Clarify external proxy availability in partner plans - #68

Open
p3ob7o wants to merge 1 commit into
mainfrom
codex/remove-domain-proxy-flag-guidance
Open

p3ob7o wants to merge 1 commit into
mainfrom
codex/remove-domain-proxy-flag-guidance

Conversation

@p3ob7o

@p3ob7o p3ob7o commented Oct 9, 2026 •

Copy link
Copy Markdown

Partner plan configuration says external proxy routes require domains.proxy_bindings. Clarify that feature grants control branding and page templates, while external proxy routes are available independently.

Validation: strict build and type checks, link validation, route verification, public-safety checks, composed-site audit, and all three corpus-generator tests passed. The changed page has zero Vale alerts. The repository-wide prose check reports two existing spelling alerts (GETs and TTYs) on unchanged pages.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@indent

indent Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Issues

All clear! No issues remaining. 🎉

1 issue already resolved
  • The new text says external proxy routes work regardless of feature grants, but monorepo main still gates them on domains.proxy_bindings for partner plans. A partner who follows the docs and omits the key would break their customers' proxy routes. The change matches behavior only after spacefast/monorepo#3883 merges and deploys.
    Found by Indent Review Agent

CI Checks

All required checks pass for 328d4de. The optional Spacefast Builds check is still running.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · Docs say proxy is ungated for partners; main still gates it until monorepo#3883 merges.
Full results

Indent Review Agent

  • Summary: Docs say proxy is ungated for partners; main still gates it until monorepo#3883 merges.
  • Last ran on commit: 328d4de3
  • Latest result
    {
      "summary": "Docs say proxy is ungated for partners; main still gates it until monorepo#3883 merges.",
      "findings": [
        {
          "fix": "Hold this PR until spacefast/monorepo#3883 merges and deploys, then merge. If it must go out first, keep the `domains.proxy_bindings` sentence until then.",
          "line": 89,
          "path": "content/platforms/partner-api/configuration.mdx",
          "issue": "The new text says external proxy routes work regardless of feature grants. On monorepo main (799a740f93) that is false. In `apps/control-plane/src/limits/resolve.ts:143-157`, `FEATURE_DIALS` still maps `domains.proxy_bindings` to `externalProxy`, and `entitlementsForFeatures` starts `externalProxy: false` for every partner plan. `resolveSpaceEntitlements` sends external-principal spaces through that path. `route-config.ts:342` and `versions/lifecycle.ts:6038` then compute `externalProxy` as `spaceClaimed && entitlements.externalProxy`. The result: on a partner plan that doesn't list `domains.proxy_bindings`, proxy rules publish with a `free_external_proxy_disabled` warning and serve the plan-restriction page. A partner who follows the new docs and drops the key from `features` would break their customers' proxy routes. The ungating ships only with the still-open monorepo PR https://github.com/spacefast/monorepo/pull/3883 (`codex/remove-domain-feature-flags`, commit 1dbcc7ff1f), which removes the dial. No other page in the docs repo mentions `proxy_bindings`. The generated OpenAPI text ('Every plan; unclaimed spaces are denied') already describes first-party plans, not partner catalogs.",
          "title": "Docs describe behavior that main does not ship: partner plans still gate external proxy on `domains.proxy_bindings`",
          "severity": "bug"
        }
      ]
    }

@spacefast
spacefast Bot had a problem deploying to preview/codex/remove-domain-proxy-flag-guidance October 9, 2026 03:09 Failure
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 60ae6d96-9be2-4ace-a4a3-9943c80221dc
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread content/platforms/partner-api/configuration.mdx
@p3ob7o
p3ob7o force-pushed the codex/remove-domain-proxy-flag-guidance branch from 8666f05 to 328d4de Compare October 9, 2026 03:27
@spacefast
spacefast Bot had a problem deploying to preview/codex/remove-domain-proxy-flag-guidance October 9, 2026 03:27 Failure

This branch had an error being deployed

1 failed deployment
preview/codex/remove-domain-proxy-flag-guidance — 328d4de3 Deployed Oct 9, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant