Skip to content

Move Storage docs off the reserved runtime route - #70

Open
batuhan wants to merge 2 commits into
mainfrom
fix/reserved-storage-docs-route
Open

batuhan wants to merge 2 commits into
mainfrom
fix/reserved-storage-docs-route

Conversation

@batuhan

@batuhan batuhan commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • move the authored Storage guide from /storage to /object-storage
  • update navigation and internal links to the new route
  • leave the actual storage API paths unchanged

Why

/storage is owned by the Spacefast runtime. The docs build succeeded, but publishing rejected its generated storage/index.html artifact as a runtime control path. Moving the authored page removes that collision without weakening the runtime path policy.

Verification

  • bun run verify:generated
  • bun run check
  • bun run validate
  • bun run build
  • bun run audit
  • bun run verify:public-safety
  • bun run verify:prose
  • bun run verify:routes
  • confirmed dist/storage/index.html is absent
  • confirmed dist/object-storage/index.html is present

View in Indent View in Slack
Tag @indent to continue the conversation here.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Documentation
    • Updated WordPress and Zero Runtime page links to point to the Object Storage page.

@indent

indent Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Issues

All clear! No issues remaining. 🎉

1 issue already resolved
  • https://spacefast.com/docs/storage/ is live today, but after this rename nothing serves it and redirects.ts has no entry, so it will 404. Bookmarks, search results and the pinned docs indexes in spacefast/monorepo still point at it. Add a 301 from /storage to /object-storage in redirects.ts. (fixed by commit 2875996)
    Found by Indent Review Agent

CI Checks

All required CI checks passed on 2875996.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · The new /docs/storage redirect fixes the earlier 404 finding, and I found no new issues.
Full results

Indent Review Agent

  • Summary: The new /docs/storage redirect fixes the earlier 404 finding, and I found no new issues.
  • Last ran on commit: 28759960
  • Latest result
    {
      "summary": "The new /docs/storage redirect fixes the earlier 404 finding, and I found no new issues.",
      "findings": []
    }

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e065a0f5-3cfa-4d1a-923b-1f114337e5f1

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d582afc3-32f1-49c4-a51c-fc077f11a3c7


📥 Commits

Reviewing files that changed from the base of the PR and between 576f708 and 8f69432.



📒 Files selected for processing (4)
  • content/(dynamic)/meta.ts
  • content/(dynamic)/object-storage.mdx
  • content/(dynamic)/wordpress.mdx
  • content/(dynamic)/zero-runtime.mdx


Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.




📝 Walkthrough
📝 Walkthrough

Walkthrough

The Dynamic metadata now lists object-storage instead of storage. Storage links in the WordPress and Zero Runtime pages now point to /object-storage.

Changes

Object-storage route updates

Layer / File(s) Summary
Update object-storage route references
content/(dynamic)/meta.ts, content/(dynamic)/wordpress.mdx, content/(dynamic)/zero-runtime.mdx
The Dynamic page list replaces storage with object-storage. Storage links in the WordPress and Zero Runtime pages now point to /object-storage.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix



Merge Risk: ⚪ Minimal · up to 8f694

The documentation route now points to the renamed guide while runtime API paths remain unchanged. No route collision or broken documentation link is evidenced, so the change is ready to merge.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: moving the Storage documentation away from the reserved /storage runtime route. It is concise and specific.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.



✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR



🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@indent

indent Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Addressed in 2875996. I verified that https://spacefast.com/docs/storage/ is live, then added a 301 to /docs/object-storage through the composed routing rules. I did not add it to redirects.ts, because Blume would recreate the forbidden dist/storage/index.html artifact. The full docs verification suite passes, the redirect is present in dist/_redirects, and no root storage artifact is emitted.

View session

This branch was successfully deployed

1 active deployment
preview/fix/reserved-storage-docs-route — 28759960 Deployed Oct 10, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant