Repository navigation
feat(tui): add ACP user question forms - #300
Merged
Merged
Conversation
danielkov
enabled auto-merge (squash)
October 22, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add capability-gated
ask_userinteractions over ACP form elicitation. The TUI supports single selection, multiple selection, inline custom answers, and paged forms with answer review before atomic submission.Technical details
Foreground-only questions
Expose
ask_useronly when the connected ACP v2 client advertises form support and the runtime setting permits it. The optional top-levelask_userconfiguration defaults to true; setting it to false disables the tool after restart. Keep questions outside backgroundable compose, bind each request to its connection and session, and distinguish accepted answers from decline and cancellation.Form interaction and validation
Keep the conversation visible above a bounded question panel. Use composer editing for text, inline Other fields alongside choices, and reversible Tab navigation that permits unanswered fields while retaining submission-time validation. Preserve stable question/option IDs on the wire and use human-readable labels in the UI. Bound request size and pending forms, reject unsupported constraints, and cancel obsolete requests without accepting stale-session answers.
Supported scope
Support session-scoped form elicitation only; URL and pre-session request-scoped elicitation are not implemented. Document keyboard controls, tool availability, configuration, and request limits.