Repository navigation
fix(ahp): validate tool input before hook dispatch - #301
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate original tool arguments against the cached current schema before constructing or dispatching
tool.before. Malformed arguments now returnFailedBeforeInvocation(InvalidInput)with the tool name and JSON instance path, instead of being reported as a hook policy denial.Technical details
Validator initialization failures return
Internal. Early validation failures skip both hook events and tool execution without coercing arguments; the existing AHP arguments contract continues to reject invalid hook edits.