Fix gateway CI failures#321
Merged
Merged
Conversation
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Changed Files
|
lucaspar
marked this pull request as ready for review
July 21, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
GITHUB_ACTIONS=true PATH="/tmp/npm-global/bin:/home/ubuntu/.nvm/versions/node/v24.18.0/bin:/home/ubuntu/.local/bin:$PATH" just generate-secrets ci --forcePATH="/home/ubuntu/.nvm/versions/node/v24.18.0/bin:/home/ubuntu/.local/bin:$PATH" uv run --extra local prek run --all-filesNote
Low Risk
Behavioral change is limited to skipping federation paths when the directory is absent; Python changes are cosmetic except for a type-safe enum for existing string constants.
Overview
generate-secrets.shno longer assumes afederationsibling checkout: it only setsFEDERATION_ROOTand chmodsfederation/.envswhen that directory exists, so gateway CI can run secret generation without the optional federation repo.The remaining Python edits are pre-commit/formatting only (import order in federation and
asset_access_control, line wrapping, whitespace).users/api/views.pydrops an unusedloguruimport and introduces aServiceUserSettingStrEnumfor the existing mint-endpoint setting comparisons—no behavior change.Reviewed by Cursor Bugbot for commit a1e6cb8. Bugbot is set up for automated code reviews on this repo. Configure here.