Repository navigation
mutate: -cache keeps the edits refused, for a run over the same code - #42
Merged
Merged
Conversation
A pull request's gate run again after a fix re-broke every package of the change: spin#493's took eleven runs, each spending its ten to sixteen minutes of mutate on edits whose answer could not have moved. An edit refused is kept under a key of the edit, of every file in the directories of the packages its tests and its importers' tests are built from, their testdata, the module's pins, the toolchain and this tool's version; the next run asks only about the rest. Off unless named: a file a test reads from outside its package is not in the key, so a run from scratch stays the one to trust. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request's gate that is run again after a fix re-broke every package of the change. spin#493 took eleven gate runs, and each spent its ten to sixteen minutes of mutate on edits whose answer could not have changed.
-cache <dir>keeps each edit the tests refused, under a key of everything that answer was read from:testdata;go.modandgo.sum;The next run asks the tests only about the rest. Only refusals are kept: a survivor fails the run, and is the next run's question.
The cache is off unless named. A file a test reads from outside its package is not in the key, so a run from scratch (spin's daily ci.yml) stays the one to trust.
Measured on spin over #493's diff (
-max 60): the second run took 54 of the 60 edits from the cache. Its time then went to the one survivor, intestutil, which every importer is asked about.Tests: a refusal is kept for the same code, and is asked again once the tests, the testdata, a package two imports down or the module's pins change. A package the tests do not reach changes nothing. Each was planted and failed.
task test,task lintandtask mutateare green (0 survived).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.