Repository navigation
versions: an image's pin is asked of its registry, not of docker - #44
Merged
Merged
Conversation
The buildx Blacksmith's builder installs printed its whole listing for imagetools inspect --format, and ami's weekly refresh wrote that as go's pin. crane.Digest asks the registry for the tag's manifest digest with the same keychain docker reads; the test runs a registry in-process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ami's first weekly refresh (refresh.yml) failed on
versions bump go: on the Blacksmith runnerdocker buildx imagetools inspect --format '{{.Manifest.Digest}}'printed its whole listing, and that became the pin (the pin "Name: mirror.gcr.io/library/golang:..." is not a sha256: digest).resolvenow asks the registry itself with go-containerregistry'scrane.Digest(already in the module graph, now direct), using the same keychain docker reads (~/.docker/config.json, credential helpers). It returns the digest of what the tag names: for a multi-platform image the index, which is what was pinned before.Checked:
task testandtask lint. The test runs a registry in-process (pkg/registry, plain HTTP for a localhost reference): a missing tag is an error, and a tag's pin is its index's digest, not another tag's.task mutate BASE=origin/main: 0 survived.bump goandbump wolfi-basegive the same digest as before, andbump pythongives the oneversions checkreported.Followup: ami bumps go-tools to this and dispatches Refresh again.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.