fix(daemon): drain the engine's pseudo-terminal before closing it - #262
Merged
Merged
Conversation
The exit goroutine closed the PTY master as soon as the engine was reaped, discarding output written just before the exit that the pump had not yet read. It now waits for the pump to reach end of stream, closing the master itself only after ptyDrainTimeout (a child of the engine can hold the slave open). Fixes #252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSupervisorPTYCapturefailures on Linux CI.ptyDrainTimeout(2s), which covers a child of the engine holding the slave open.Key changes
internal/daemon/supervisor.go: wait for the pump before closing the master, with a timeout.internal/daemon/supervisor_pty_test.go: a test for the lingering-child timeout.docs/maintainer/internals.md: note on why the master is not closed on exit.Fixes #252