Repository navigation
fix: pin Python at the minor, so new Ubuntu images work - #72
Merged
Merged
Conversation
thatsrue
changed the title
3 tasks done
thatsrue
added a commit
that referenced
this pull request
Oct 31, 2026
## What changed `convert_to_wav` no longer opens its input with libsndfile before ffmpeg runs. It still reads the duration (for the ffmpeg timeout) from libsndfile when it can, and from `ffprobe` when it can't. That helper is now public as `input_duration`, and `process_file` uses it for the timing report's input probe too. `AGENTS.md` notes that `ffprobe` is needed next to `ffmpeg`. ## Why `.m4a` and `.aac` are in `SUPPORTED_FORMATS` and the batch accepts them, but libsndfile 1.2.2 has no AAC or MP4 decoder. The input probe raised inside `convert_to_wav`'s `try`, so every such file failed as "Failed to convert" before ffmpeg, which decodes them fine, was ever called. The same libsndfile read in `process_file`'s input probe set `input_audio_seconds` to `None` for these files with no warning. Those tracks had no speed figure in the batch table, and `<session>-metrics.json` left their audio out of the session total. Closes #73 ## How you checked it - New `test_formats_libsndfile_cannot_read_convert_through_ffmpeg` (`.m4a` and `.aac`, encoded by real ffmpeg): passes with the fix, both cases fail on `dfdd18b` with the `AudioValidationError` from the issue. - New `test_input_seconds_recorded_for_formats_libsndfile_cannot_read` (`.m4a` and `.aac`, through `process_file`): passes with the fix, both cases fail with the previous `pipeline.py`. - `make lint`, `make typecheck`: pass. `make test-fast`: 300 passed. - Slow (inference) tests not run: they feed WAV input, whose path through `convert_to_wav` is unchanged. - Confirmed locally that the installed libsndfile 1.2.2 lists no AAC or MP4 format. - CI fails at `setup-python` before any check runs: `.python-version` pins 3.14.3, which has no build for the Ubuntu 26.04 runner. It fails the same way on other branches; #72 fixes it. - [x] A bug fix comes with a test that fails without it - [x] Docs match how it works now - [x] No secrets or private information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Moves
.python-versionfrom 3.14.3 to 3.14, so patches float, and the docs with it.Why
setup-pythonfails on Ubuntu 26.04 with 3.14.3, which stops every job.Closes #71
How you checked it
versions-manifest.jsonlists 3.14 patches for Ubuntu 26.04