Skip to content

fix: name a linked track's output by the link, not its target - #80

Merged
thatsrue merged 1 commit into
mainfrom
fix/review-75
Oct 31, 2026
Merged

thatsrue merged 1 commit into
mainfrom
fix/review-75

Conversation

@thatsrue

Copy link
Copy Markdown
Collaborator

What changed

process_file names every per-track output (converted WAV, manifest, checkpoint, mapping, JSON, VTT) from the path it was given, not from the symlink's target. It still reads the audio through the link.

Why

A track linked as tmp/input/s11/4-pikel.flac → 4-pikel_123.flac landed in s11/4-pikel/ but wrote 4-pikel_123.vtt. The batch combine looks for 4-pikel/4-pikel.vtt (vtt_path_for_input) and raised "Transcript files not found". The folder already followed the link's name; the file names now do too.

Left out: combobulator filter-vtt resolves its input before locating the output folder, so it does not find a linked track's output either. That is a separate fix.

Closes #75

How you checked it

  • A bug fix comes with a test that fails without it: test_link_named_unlike_its_target_writes_the_vtt_combine_reads fails on main and passes here
  • make lint, make typecheck, and pytest -m "not slow" (297 passed) exit 0. Slow inference tests not run; non-linked tracks get the same names as before
  • Docs match how it works now
  • No secrets or private information

@thatsrue
thatsrue merged commit 606fa8a into main Oct 31, 2026
4 checks passed
@thatsrue
thatsrue deleted the fix/review-75 branch October 31, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Symlink whose name differs from its target breaks combine

1 participant