Repository navigation
fix: name a linked track's output by the link, not its target - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
process_filenames every per-track output (converted WAV, manifest, checkpoint, mapping, JSON, VTT) from the path it was given, not from the symlink's target. It still reads the audio through the link.Why
A track linked as
tmp/input/s11/4-pikel.flac→4-pikel_123.flaclanded ins11/4-pikel/but wrote4-pikel_123.vtt. The batch combine looks for4-pikel/4-pikel.vtt(vtt_path_for_input) and raised "Transcript files not found". The folder already followed the link's name; the file names now do too.Left out:
combobulator filter-vttresolves its input before locating the output folder, so it does not find a linked track's output either. That is a separate fix.Closes #75
How you checked it
test_link_named_unlike_its_target_writes_the_vtt_combine_readsfails on main and passes heremake lint,make typecheck, andpytest -m "not slow"(297 passed) exit 0. Slow inference tests not run; non-linked tracks get the same names as before