Repository navigation
fix(batch): reject inputs that share a stem before any work - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
combobulator runexits 1 before loading config or starting workers when two inputs share a file stem, ignoring case (1-cadderly.flacand1-cadderly.wav), and names both files.AGENTS.mdBatch Run Behaviour says so. Case is ignored as in the bundle check (bundle.py), since on a case-insensitive filesystem1-Cadderlyand1-cadderlyname one output folder.Why
The stem names the output folder, so both files went to parallel workers writing the same WAV, segments, progress file and manifest at once, and combine got the same VTT path twice.
Closes #76
How you checked it
tests/test_batch.py::TestDuplicateStemsrunsmainon a folder withjfk_1.flacandJFK_1.wav: fails without the fix (the run goes on to the speaker-mapping step), passes with it.make lint,make typecheck,make test-fast(297 passed, 9 slow deselected) andpython -m build: exit 0. Slow tests not run; the change is before any audio work.A bug fix comes with a test that fails without it
Docs match how it works now
No secrets or private information