Repository navigation
fix: run the package build in the pre-push hook - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The pre-push hook also runs
make build(python -m build, as the CIbuildjob does). Adds thebuildtarget, pinsbuild==1.6.1in thedevextra, ignores/dist/, and updates AGENTS.md and docs/README.md.Why
The hook said it ran what CI runs "minus the package build", so a packaging error passed the hook and failed CI.
make test-fastalready matches CI:testpaths = ["tests"]and-m "not slow"give the same selection (303 passed, 9 deselected).Closes #85
How you checked it
lefthook run pre-push --forceexits 0: ruff, mypy, 303 tests passed and 9 deselected, and the sdist and wheel built. Hook behaviour has no test file. Thebuildpin is new: CI installsbuildunpinned.