Disallow logging.conf from elsewhere than the app folder - #825
Open
Ickerday wants to merge 1 commit into
Open
Conversation
mateusz834
reviewed
Jul 29, 2026
|
|
||
| splunk_home = path.abspath(path.join(getcwd(), environ.get("SPLUNK_HOME", ""))) | ||
| app_file = getattr(sys.modules["__main__"], "__file__", sys.executable) | ||
| app_root = path.dirname(path.abspath(path.dirname(app_file))) |
Member
There was a problem hiding this comment.
Is that even correct? What if the CSC python file is inside bin/foo/bar/csc.py i don't think this will find the app dir correct, right?
There is an assumption that csc files are in bin/csc.py.
mateusz834
reviewed
Jul 29, 2026
| if path.exists(configuration_file): | ||
| filename = configuration_file | ||
| break | ||
| elif not path.isabs(filename): |
Member
There was a problem hiding this comment.
Shouldn't we update this branch too? It will hit when filename is a relative path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.