Skip to content

Remove timeout dependency from SSE tests - #146

Open
codingkiddo wants to merge 1 commit into
spring-projects:mainfrom
codingkiddo:fix/portable-sse-timeout
Open

Remove timeout dependency from SSE tests#146
codingkiddo wants to merge 1 commit into
spring-projects:mainfrom
codingkiddo:fix/portable-sse-timeout

Conversation

@codingkiddo

Copy link
Copy Markdown

Summary

Remove the GNU timeout command dependency from SSE endpoint testing.

The existing implementation launches curl through:

timeout 10 curl ...

However, timeout is not available by default on macOS, which causes the SSE test process to fail before curl is started.

This change uses curl's built-in timeout support instead:

curl --max-time 10 ...

Changes

  • Remove the external GNU timeout dependency.
  • Use curl --max-time 10 to limit SSE test duration.
  • Preserve the existing 10-second timeout behavior.

Testing

Verified locally on macOS where:

command -v timeout

returns no command, while curl is available.

Also verified that the installed curl supports:

--max-time

This keeps the SSE test behavior while improving portability across environments.

Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant