Remove timeout dependency from SSE tests - #146
Open
codingkiddo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the GNU
timeoutcommand dependency from SSE endpoint testing.The existing implementation launches
curlthrough:However,
timeoutis not available by default on macOS, which causes the SSE test process to fail beforecurlis started.This change uses curl's built-in timeout support instead:
Changes
timeoutdependency.curl --max-time 10to limit SSE test duration.Testing
Verified locally on macOS where:
returns no command, while
curlis available.Also verified that the installed curl supports:
This keeps the SSE test behavior while improving portability across environments.