Conversation
We now pre-process the cache key for Kotlin typed path references as Kotlin creates a new lambda instance per invocation while non-capturing Java lambdas result in a single instance per declaration site.
Add value semantics to KSinglePropertyReference and KIterablePropertyReference. Move off our own isLambdaClass(…) implementation in favor of Spring Framework's ClassUtils.isLambdaClass(…) utility method.
Kotlin (SAM-converted Lambdas) and Java capturing lambdas declare constructors that require the capturing argument and thus cannot be instantiated with a zero-arg constructor. We skip capturing lambda registrations entirely. For SAM-converted Kotlin lambdas, we introspect their metadata and obtain model information through KPropertyReferenceDescriptor. This isn't ideal as this registers reflection for every reachable Kotlin property reference in the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now introspect the property-path Lambda cache key for Kotlin lambdas as Kotlin creates an instance per invocation rendering our cache useless.
Also, move off own helpers to Spring Framework utils, avoid instantiation of capturing lambdas in
TypedPropertyPathFeatureand register reflection hints for SAM-converted Kotlin lambdas.Closes #3521