Accept @Nullable contextPath in ServerHttpRequest.Builder - #37150
Closed
yashsiwacha wants to merge 1 commit into
Closed
Accept @Nullable contextPath in ServerHttpRequest.Builder#37150yashsiwacha wants to merge 1 commit into
yashsiwacha wants to merge 1 commit into
Conversation
Mark the contextPath parameter as @nullable in both the ServerHttpRequest.Builder interface and DefaultServerHttpRequestBuilder implementation. Previously, although DefaultServerHttpRequestBuilder handled null values internally (e.g., in MutatedServerHttpRequest and DefaultRequestPath.initContextPath()), the public interface lacked the @nullable annotation. In a @NullMarked package, this caused compile-time validation issues (such as under NullAway) for callers trying to pass null to reset/clear the context path. Closes spring-projectsgh-37098 Signed-off-by: Yash Siwach <yashsiwach07@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: web
Member
|
Closing as a duplicate of: In the future, please:
Thanks |
sbrannen
added
status: duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the
contextPathparameter as@Nullablein both theServerHttpRequest.Builderinterface andDefaultServerHttpRequestBuilderimplementation.Previously, although
DefaultServerHttpRequestBuilderhandled null values internally (e.g., inMutatedServerHttpRequestandDefaultRequestPath.initContextPath()), the public interface lacked the@Nullableannotation. In a@NullMarkedpackage, this caused compile-time validation issues (such as under NullAway) for callers trying to passnullto reset/clear the context path.Closes gh-37098