Fix broken internal xref links in reference docs

[Gabriel-Gerhardt]

Several xref: links in framework-docs/modules/ROOT/pages point at anchors that don't exist, most likely left over from the 2023 migration to Antora or later content reorganizations. All internal xref: links in the docs module were compared against the anchors actually defined in their target files; these are the ones that don't resolve.

• testing/resttestclient.adoc: three self-references used hyphenated ids (resttestclient-workflow/-assertj/-json) instead of the dotted ids the file actually defines (resttestclient.workflow/.assertj/.json).
• web/webflux/config.adoc and web/webmvc/mvc-config/content-negotiation.adoc referenced mvc-ann-requestmapping-suffix-pattern-match, which no longer exists — the section was renamed to mvc-ann-requestmapping-rfd when RFD coverage was added. content-negotiation.adoc had both the stale and current link side by side, so the stale one was dropped.
• web/webmvc-test.adoc linked to web-reactive.adoc#webflux-test, but that page defines no such anchor; the real target is web/webflux-test.adoc.
• data-access/transaction/strategies.adoc and core/appendix/xml-custom.adoc referenced appendix anchors with the wrong prefix (missing appendix. in one place, an extra core.appendix. in six others).
• testing/testcontext-framework/ctx-management/groovy.adoc linked to core/beans/basics.adoc#beans-factory-groovy, but that section now lives in languages/groovy.adoc.
• core/aop/schema.adoc linked to #aop in xsd-schemas.adoc, which defines the anchor as xsd-schemas-aop.

Docs-only change, no functional code touched.

[sbrannen]

Hi @Gabriel-Gerhardt,

Good catches, and congratulations on submitting your first PR to the Spring Framework! 👍

Out of curiosity, how did you discover those broken links?

In any case, the build currently fails. So, please make sure you run the build locally (./gradlew antora) before submitting PRs or pushing commits to a PR.

In resttestclient.adoc, it looks like you'll need to include the filenames in addition to the anchors.

For example, xref:testing/resttestclient.adoc#resttestclient.workflow instead of just xref:resttestclient.workflow, and likewise for xref:resttestclient.assertj.

In addition, please base this PR on the 7.0.x branch, so that we can apply it there and forward merge to main. Feel free to "force push" your changes to this PR once you're done.

Cheers,

Sam

[Gabriel-Gerhardt]

Hi @sbrannen,

Thanks for the review and the warm welcome!

Regarding how I found them, I used an AI-assisted scan to compare every internal xref: link in the docs module against the anchors actually defined in their target files, then verified the mismatches by hand before fixing them.

I've addressed all three points:

• resttestclient.adoc now uses the full-path form for the self-references, e.g. xref:testing/resttestclient.adoc#resttestclient.workflow and #resttestclient.assertj, matching the pattern already used for #resttestclient.json.
• Verified ./gradlew antora runs clean locally with no warnings or errors.
• Force pushed the 2 commits after the rebase.

Let me know if anything else needs adjusting.

[sbrannen]

Thanks for the review and the warm welcome!

👍

Regarding how I found them, I used an AI-assisted scan to compare every internal xref: link in the docs module against the anchors actually defined in their target files, then verified the mismatches by hand before fixing them.

Thanks for sharing.

I've addressed all three points:

That looks better now. Thanks.

Let me know if anything else needs adjusting.

Yes, I added a request to rebase on 7.0.x, but you may have missed that since I edited my original comment:

In addition, please base this PR on the 7.0.x branch, so that we can apply it there and forward merge to main. Feel free to "force push" your changes to this PR once you're done.

If you don't have time to do that, I can just manually merge the PR onto 7.0.x, but then GitHub will mark this PR as "closed" instead of "merged". So, it's up to you.

Let me know how you want to proceed.

[Gabriel-Gerhardt]

Just changed the base branch to 7.0.x as requested, so this should be ready to merge normally now whenever you get a chance. Thanks again for the review!

[github-actions]

Fixed via 507406c

[sbrannen]

This has been merged into 7.0.x and main.

Thanks