Repository navigation
Conversation
…tory Signed-off-by: Paolo Fosser <pfosser@libero.it>
artembilan
reviewed
Oct 19, 2026
| props.setProperty("jcifs.smb.client.minVersion", this.getSmbMinVersion().name()); | ||
| props.setProperty("jcifs.smb.client.maxVersion", this.getSmbMaxVersion().name()); | ||
| props.setProperty("jcifs.client.minVersion", this.getSmbMinVersion().name()); | ||
| props.setProperty("jcifs.client.maxVersion", this.getSmbMaxVersion().name()); |
Member
There was a problem hiding this comment.
From jCIFS itself:
final String minVer = p.getProperty("jcifs.client.minVersion");
final String maxVer = p.getProperty("jcifs.client.maxVersion");
I wish they had constants class on the matter instead of us trying to scan their source code for proper names...
But thank you anyway!
Will be merged next week.
Contributor
Author
There was a problem hiding this comment.
So do I, and wonder why on earth they don't. Perfect way to break client code.
Anyway I have to admit that Claude did that scan for me...
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the jcfis property keys, changed in jcifs 3.0.0