Missing required field goes unreported when its path shares a prefix with an absent optional field - #1057
Merged
Conversation
wilkinsona
changed the title
wilkinsona
added
type: bug
…stor isNestedBeneathMissingOptionalField used a plain string prefix test, so a required field whose path merely shared a string prefix with an absent optional field's path (for example optional 'a' and required 'ab') was treated as nested beneath it and its absence was never reported. Require the path to continue with a '.' or '[' segment boundary after the ancestor path. See spring-projectsgh-1057 Signed-off-by: seonghun lee <harrisleesh@gmail.com>
Member
|
Thanks again, @hunseonglee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-1054
JsonContentHandler.isNestedBeneathMissingOptionalFieldused a plain string prefix test, so a required field whose path merely shared a string prefix with an absent optional field's path (optionala+ requiredab, or optionala.b+ requireda.bc) was treated as nested beneath it, andfindMissingFields()never reported it — the snippet was generated with the missing required field undetected.resolveFieldTypewas affected the same way.The check now requires the descendant path to continue with a
.or[segment boundary after the ancestor path. Added regression tests that fail onmainand pass with the fix; all payload tests andspring-restdocs-corechecks pass.