fix(postgresql): keep spaces around OPERATOR() with denseOperators#958
Open
sarathfrancis90 wants to merge 1 commit into
Open
fix(postgresql): keep spaces around OPERATOR() with denseOperators#958sarathfrancis90 wants to merge 1 commit into
sarathfrancis90 wants to merge 1 commit into
Conversation
With denseOperators the PostgreSQL OPERATOR(schema.op) construct was densed into its operands, e.g. "foo OPERATOR(public.===) bar" became "fooOPERATOR(public.===)bar", which re-parses as invalid SQL. It's a keyword-like operator, so it now keeps its surrounding spaces like the dashed "-" case does.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughIn ChangesOPERATOR() dense-operator spacing fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying out
denseOperatorson some Postgres queries and noticed it mangles theOPERATOR(schema.op)syntax:The spaces around the operator get stripped, so
fooruns into theOPERATORkeyword and the result no longer parses. Unlike+/=/etc., this one is keyword-like and can't be glued to its operands, so I made it keep its surrounding spaces even in dense mode — same idea as the existing-exception for dialects with dashed identifiers.Added a test under the existing OPERATOR() case in postgresql.test.ts.