Repository navigation
fix: publish documentation styles and new pages - #645
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the missing styles at https://sql.js.org/documentation/ by including newly generated documentation files in the Pages deployment commit.
The build artifact contains the CSS, JavaScript, and new API routes, but the deployment action copies the development
.gitignoreintogh-pagesand runsgit add --all .. Sincedocumentation/is ignored, only previously tracked files are updated. The resulting HTML references assets that were never committed and return 404. This also prevents the new API pages from being published.Override that ignore rule only in the deployment job, before the action copies and stages the files. Generated documentation remains ignored during normal development, and
.nojekylland all other ignore rules are preserved.Verification
gh-pages..gitignoreand tracked index, and the action's rsync /git add --all .behavior: 80 of 81 documentation files were excluded before the fix..nojekyllis retained andnode_modules/is still ignored.npm run docnpm run lintgit diff --check