Skip to content

fix: publish documentation styles and new pages - #645

Merged
lovasoa merged 1 commit into
masterfrom
fix/documentation-pages-assets
Oct 26, 2026
Merged

lovasoa merged 1 commit into
masterfrom
fix/documentation-pages-assets

Conversation

@lovasoa

@lovasoa lovasoa commented Oct 26, 2026

Copy link
Copy Markdown
Member

Summary

Fix the missing styles at https://sql.js.org/documentation/ by including newly generated documentation files in the Pages deployment commit.

The build artifact contains the CSS, JavaScript, and new API routes, but the deployment action copies the development .gitignore into gh-pages and runs git add --all .. Since documentation/ is ignored, only previously tracked files are updated. The resulting HTML references assets that were never committed and return 404. This also prevents the new API pages from being published.

Override that ignore rule only in the deployment job, before the action copies and stages the files. Generated documentation remains ignored during normal development, and .nojekyll and all other ignore rules are preserved.

Verification

  • Confirmed the live stylesheet returns HTTP 404 and is present in the latest successful CI documentation artifact, but absent from gh-pages.
  • Reproduced the deployment locally using that artifact, the existing Pages .gitignore and tracked index, and the action's rsync / git add --all . behavior: 80 of 81 documentation files were excluded before the fix.
  • Executed the new workflow step in the same simulation: all 81 documentation files were staged, including the stylesheet, 14 island JavaScript modules, and the new API pages. Confirmed .nojekyll is retained and node_modules/ is still ignored.
  • npm run doc
  • npm run lint
  • git diff --check

@lovasoa
lovasoa merged commit b586e36 into master Oct 26, 2026
4 checks passed
@lovasoa
lovasoa deleted the fix/documentation-pages-assets branch October 26, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant