Skip to content

Fix DBMS name/version reporting fallback and resume detection - #6119

Closed
tanaydin wants to merge 1 commit into
sqlmapproject:masterfrom
tanaydin:fix-dbms-fallback-detection
Closed

tanaydin wants to merge 1 commit into
sqlmapproject:masterfrom
tanaydin:fix-dbms-fallback-detection

Conversation

@tanaydin

Copy link
Copy Markdown
Contributor

Summary

  • Format.getDbms() / Backend.getDbms() now fall back to conf.dbms when kb.dbms isn't set yet, so a formatted DBMS+version string no longer drops the DBMS name or prints "None" before fingerprinting completes.
  • _resumeDBMS() in lib/core/target.py now also propagates the DBMS/version into Backend when resuming a session where the DBMS wasn't previously stored, and preserves the previously detected version when the resumed value is unknown.
  • Minor simplification cleanups in lib/core/option.py (non-SQL technique switch validation, tamper priority check, kb.chars/kb.multibit initialization).
  • Added unit tests in tests/test_misc.py covering the Format.getDbms() fallback behavior.

Test plan

  • python tests/test_misc.py (new TestFormatGetDbms cases pass)

Format.getDbms() now falls back to conf.dbms (and Backend.getDbms()
falls back to conf.dbms as well) when kb.dbms isn't set yet, so a
version-only result no longer drops the DBMS name or prints "None".
_resumeDBMS() in target.py now also sets Backend's DBMS/version when
resuming a session where the DBMS wasn't previously fingerprinted.
Also simplifies several option.py helpers (non-SQL technique lookup,
tamper priority validation, kb.chars/multibit setup) and adds unit
tests for the getDbms() fallback behavior.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@stamparm

Copy link
Copy Markdown
Member

that is not how this is done. changing 4 files for sqlmap, without even opening an issue or asking whether you could do it will always result with close down

@stamparm stamparm closed this Sep 14, 2026
@stamparm

Copy link
Copy Markdown
Member

you really think that i could merge something like Minor simplification cleanups in lib/core/option.py (non-SQL technique switch validation, tamper priority check, kb.chars/kb.multibit initialization). without any issue where you explain "your problem" first? no way

@tanaydin

tanaydin commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Ok, I'll try to provide a working test for this, it's hard to reproduce, "sometimes" I'm hitting that bug.

@stamparm

Copy link
Copy Markdown
Member

man, you open an issue describing your "problem", then you leave me to try to fix it. if i get stuck (i doubt it), you can do your pull request. that's the way this story goes. this is wrong repo for gaining merge points

@tanaydin

Copy link
Copy Markdown
Contributor Author

not looking for gain any points. will track correct way. thank you for explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants