Repository navigation
Improve Codebase :: Misc #1389
Description
I have started on this path with #1382 but I thought it would be worth creating an issue to track all of the changes I'm thinking about that will come after this. This audit was done with the help of Claude.
Small, independent, and mostly deletions the compiler can verify.
| # | Item | Where |
|---|---|---|
| E1 | Leftover dbg!(&normalized_path, &self.contents); in the routing test store. It prints on every lookup in every routing test. It is the only dbg! in src/. |
routing.rs:640 |
| E2 | type H0 and impl CanHelp for H0 — no call sites |
template_helpers.rs:12, :523-530 |
| E3 | impl From<URLParameters> for String — no call sites |
url_parameters.rs:130-134 |
| E4 | impl ResponseError for ErrorWithStatus — unreachable. Every construction site converts to anyhow::Error immediately, and the status is recovered by downcast at error.rs:212. Its body text never ships. |
error_with_status.rs:20-38 |
| E5 | impl From<AnyKind> for SupportedDatabase — reachable only through otel_name_from_kind, whose callers all pass a SupportedDatabase. It also maps Odbc → Generic, which contradicts DbInfo::database_type. |
database/mod.rs:115-125 |
| E6 | strip_site_prefix is a no-op when called from serve_file: routing.rs:169 already stripped the prefix before Serve(path) was built |
http.rs:480-482, called at :446 |
| E7 | telemetry::shutdown_telemetry() runs only on graceful shutdown. Both std::process::exit(1) paths (main.rs:14, :35) skip it, so traces are lost for exactly the failures traces exist to explain. |
main.rs:53 |
| E8 | Root test.hurl is orphaned. Both discovery sites use find examples -mindepth 2 -maxdepth 2 -name test.hurl, which cannot match a file at the repository root. |
scripts/test-examples-hurl.sh:74, ci.yml:422 |
| E9 | .dockerignore:9 excludes mssql/, which does not exist in the repository. .dockerignore:3 excludes sqlpage.db, but Docker anchors that pattern to the root, so sqlpage/sqlpage.db is not excluded and Dockerfile:43 copies it into the image. |
.dockerignore |
| E10 | sqlpage.service duplicates ProtectClock=true on lines 42 and 47. Nothing in CI validates the unit file parses. |
sqlpage.service |
Activity
lovasoa commentedon Aug 18, 2026
I do really appreciate this and thank you for your work ! But I'm having a hard time managing these bulk ai-generated issues that touch many distinct topics.
I'm closing this for the same reason as #1386 (comment) .
81reap commentedon Aug 18, 2026
oh maybe I misunderstood the ask. is it to just reopen as individual issues? or maybe even straight to PR with proper description if the change is small enough like the ones in this issue?
lovasoa commentedon Aug 20, 2026
If the change is small and you think it's uncontroversial, then yes, I think a small PR with a short clear human written description is best.
If you need confirmation that what you found is indeed an issue and not intended behavior, if there is no obvious fix that does not involve some kind of tradeoff, if the PR would be large (let's say > +200 net lines), then I'd appreciate if we could coordinate over an issue first. And I'd also prefer if you could handwrite the issue text rather than letting th machine do it.