Repository navigation
Consolidate chart documentation tests and isolate rendering assertions - #1560
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart tests previously loaded the full 17-chart documentation page eight times, repeatedly hitting Chromium's slow
:has()style invalidation. Keep one small documentation integration test with named steps that verifies the reference page, every inline and embedded chart, completed initialization, and browser errors.Move legend visibility, labeled reference lines/bands, and horizontal-axis checks to four minimal SQL fixtures using the existing Playwright harness. Extend the existing stacking fixture to preserve alignment and zero-height coverage at both missing endpoints instead of adding duplicate stacking tests. The legend check also verifies that legends appear by default.
Validation:
npm test: 82 tests passed; 92 existing lint warnings.npm run build: passed.