Revert kotlinpoet to 2.3.0, the last version built with Kotlin 2.3 - #3716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts kotlinpoet from 2.4.0 to 2.3.0 (the renovate bump in e7ff74c).
kotlinpoet 2.4.0 is built with Kotlin 2.4: its published module metadata requires kotlin-stdlib 2.4.20, while 2.3.0 requires 2.3.20. wire-schema exposes kotlinpoet as an api dependency, so Wire 7.0.0 puts Kotlin 2.4 metadata on consumer compile classpaths. Consumers that compile with Kotlin 2.2 cannot read that metadata and fail to compile. Evidence: cashapp/misk#3928 (misk pins Kotlin 2.2.21 and needed a kotlinpoet force to build against Wire 7.0.0).
2.3.0 is the newest kotlinpoet release not built with Kotlin 2.4; there is no 2.3.x after it. A comment on the pin marks the constraint, since renovate will re-open the bump.
Wire 7.0.1 follows with this revert.
Verification
Local, at this head:
:wire-schema:compileKotlinJvm,:wire-kotlin-generator:compileKotlin,:wire-compiler:compileKotlin: BUILD SUCCESSFUL.:wire-kotlin-generator:spotlessCheck: BUILD SUCCESSFUL.dependencyInsighton:wire-kotlin-generatorcompileClasspath resolves kotlinpoet 2.3.0.