Integrate the expanded core icon catalog - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Theme 0.4.0 expands the provider-neutral core icon catalog from 12 to 30 icons, and Engine 0.5.0 embeds that catalog. The native CLI still pinned Engine 0.4.0 and Theme 0.3.0, so offline CLI renders could not use the newly approved icons.
Implementation Approach
gatewayicon in the release render fixture and require its embedded SVG metadata.Testing Approach
cargo +stable fmt --checkcargo +stable test --lockedcargo audit --json: 0 vulnerabilities and 0 informational warningsReview Perspectives / Points of Concern