Skip to content

Accept provider icon namespaces - #9

Merged
konojunya merged 1 commit into
mainfrom
jj/provider-icon-namespaces
Sep 4, 2026
Merged

Accept provider icon namespaces#9
konojunya merged 1 commit into
mainfrom
jj/provider-icon-namespaces

Conversation

@konojunya

Copy link
Copy Markdown
Member

Summary

  • accept the specification-defined provider:icon-name form while preserving existing theme-local IDs
  • reject malformed, uppercase, empty, and multiply namespaced provider icon IDs with STK3013
  • keep namespaced IDs unchanged in normalized IR
  • pin the merged specification revision containing the new conformance fixture

Verification

  • cargo test --workspace --locked
  • STACK_SPECIFICATION_DIR=../specification cargo test --features conformance --test conformance --locked
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --locked
  • cargo llvm-cov --lib --all-features --workspace --locked --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95 (97.68% regions, 98.78% functions, 98.47% lines)
  • cargo +1.85.0 test --workspace --locked
  • cargo +1.85.0 clippy --workspace --all-targets --all-features --locked -- -D warnings

@konojunya
konojunya merged commit 4a18fac into main Sep 4, 2026
2 checks passed
@konojunya
konojunya deleted the jj/provider-icon-namespaces branch September 4, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant