Expand the provider-neutral core icon catalog - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The bundled catalog currently covers 12 broad client and compute concepts, while common network, delivery, data, development, and collaboration roles require either fallback artwork or vendor-specific packs. Brand and vendor artwork remains user-imported; the core catalog should provide a more useful provider-neutral baseline without redistributing third-party assets.
Implementation Approach
sha256:9cb3de8b504acbf22c93cea5fbea66be50f38734dc1dee18b9cab7084082cc1fcurrentColorrenderingTesting Approach
npm run validatenpm run generate:checknpm testnpm run typecheckcargo +stable fmt --checkcargo +stable test --workspace --lockedcargo +stable clippy --workspace --all-targets --locked -- -D warningsRUSTDOCFLAGS="-D warnings" cargo +stable doc --workspace --no-deps --lockedcargo +1.85.0 test --workspace --lockedcargo +1.85.0 clippy --workspace --all-targets --locked -- -D warningsnpm pack --dry-run --json --workspace @stack-sh/themecargo +stable package -p stack-theme --lockedReview Perspectives / Points of Concern
gateway,load-balancer,dns,cdn,network, andaifor visual distinction at small sizes