Skip to content

Expand the provider-neutral core icon catalog - #10

Merged
konojunya merged 1 commit into
mainfrom
jj/expand-core-icon-catalog
Sep 4, 2026
Merged

Expand the provider-neutral core icon catalog#10
konojunya merged 1 commit into
mainfrom
jj/expand-core-icon-catalog

Conversation

@konojunya

Copy link
Copy Markdown
Member

Background

The bundled catalog currently covers 12 broad client and compute concepts, while common network, delivery, data, development, and collaboration roles require either fallback artwork or vendor-specific packs. Brand and vendor artwork remains user-imported; the core catalog should provide a more useful provider-neutral baseline without redistributing third-party assets.

Implementation Approach

  • bump the catalog and both distribution packages to 0.4.0
  • add 18 original Stack-authored 24x24 outline SVGs, expanding the explicit catalog from 12 to 30 icons
  • cover networking, delivery, events, search, analytics, source workflows, secrets, general collaboration tools, and AI systems
  • preserve the existing node-kind fallbacks and user-imported provider-pack boundary
  • regenerate identical Cargo and npm catalog artifacts with revision sha256:9cb3de8b504acbf22c93cea5fbea66be50f38734dc1dee18b9cab7084082cc1f
  • add a regression test for Apache-2.0 provenance, redistribution permissions, and single-color currentColor rendering

Testing Approach

  • npm run validate
  • npm run generate:check
  • npm test
  • npm run typecheck
  • cargo +stable fmt --check
  • cargo +stable test --workspace --locked
  • cargo +stable clippy --workspace --all-targets --locked -- -D warnings
  • RUSTDOCFLAGS="-D warnings" cargo +stable doc --workspace --no-deps --locked
  • cargo +1.85.0 test --workspace --locked
  • cargo +1.85.0 clippy --workspace --all-targets --locked -- -D warnings
  • npm pack --dry-run --json --workspace @stack-sh/theme
  • cargo +stable package -p stack-theme --locked
  • reviewed the dependency-free gallery at 1440x1000 and 390x844: 3 themes, 30 fallbacks, 90 explicit cards, and 120 inline SVGs; no horizontal overflow, clipped cards, console errors, page errors, or failed requests

Review Perspectives / Points of Concern

  • confirm that each added icon reads as a generic concept rather than a particular vendor or product mark
  • compare gateway, load-balancer, dns, cdn, network, and ai for visual distinction at small sizes
  • confirm the additive 0.4.0 catalog version and the planned provider-first merge order before Engine integration
  • no third-party visual asset or vendor byte is included

@konojunya
konojunya merged commit 2347315 into main Sep 4, 2026
2 checks passed
@konojunya
konojunya deleted the jj/expand-core-icon-catalog branch September 4, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant