Skip to content

Publish the expanded core icon catalog - #12

Merged
konojunya merged 1 commit into
mainfrom
jj/expand-core-icon-catalog
Sep 4, 2026
Merged

Publish the expanded core icon catalog#12
konojunya merged 1 commit into
mainfrom
jj/expand-core-icon-catalog

Conversation

@konojunya

Copy link
Copy Markdown
Member

Background

Theme 0.4.0 and Engine 0.5.0 expand the provider-neutral core icon catalog from 12 to 30 icons. The Web playground and multilingual documentation still pinned Engine 0.4.0 and exposed only the original catalog.

Implementation Approach

  • Pin the published @stack-sh/engine@0.5.0 release and its registry integrity.
  • Add all 18 new provider-neutral IDs and stable subjects to the English, Japanese, Simplified Chinese, and Korean documentation.
  • Render all 30 icons in the local VitePress gallery without duplicating Theme SVG assets.
  • Exercise the new gateway icon in the default Playground source.
  • Update documentation validators to require Engine 0.5.0, all 30 IDs, and exactly 30 rendered cards per locale.

Testing Approach

  • Clean registry install with npm 11.15.0 and npm ci --no-audit
  • npm run format:check
  • npm run lint
  • npm test: 18 tests across 6 files
  • npm run build: Playground plus 48 validated documentation pages
  • npm run cloudflare:check
  • npm audit --json: 0 vulnerabilities across all severities
  • Browser QA at 1440x1000 and 320x844: 30 cards and 30 loaded images, no page or card overflow, Engine 0.5.0 / Theme Catalog 0.4.0 metadata, light/dark switching, and all four locales

Review Perspectives / Points of Concern

  • Confirm the catalog remains provider-neutral and does not introduce vendor or project marks.
  • Confirm the table subjects match the canonical Theme catalog.
  • Confirm the gallery continues to render through the published Engine WASM package rather than copied SVG assets.
  • Confirm the 320px single-column layout remains usable with the longer catalog.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stack-web cbac9b5 Commit Preview URL

Branch Preview URL
Sep 04 2026, 10:41 AM

@konojunya
konojunya merged commit f21efc0 into main Sep 4, 2026
2 checks passed
@konojunya
konojunya deleted the jj/expand-core-icon-catalog branch September 4, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant