fix: Remove the hardcoded image repository from values.yaml - #445
Open
lfrancke wants to merge 1 commit into
Open
fix: Remove the hardcoded image repository from values.yaml#445lfrancke wants to merge 1 commit into
lfrancke wants to merge 1 commit into
Conversation
commons-operator was the only operator setting image.repository in its own
values.yaml. The other 13 non-CSI operators leave it to the registry overlay in
deploy/helm/commons-operator/values/, which publish-helm-chart merges on top at
package time.
The value was also wrong in shape. operator.image renders
"{repository}/{Chart.Name}:{tag}", so repository is the namespace and the chart
name is appended. The hardcoded value already contained the name, so had it ever
taken effect it would have produced .../sdp/commons-operator/commons-operator.
No behaviour change for published charts: the overlay wins the merge either way.
Techassi
approved these changes
Aug 7, 2026
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm looking into adding a Values schema and had Claude analyse our values file. commons-operator is the only one setting
image.repositoryin its own values file. The others leave it to the registry overlay in deploy/helm/commons-operator/values/.In addition the value was also wrong. So, due to the overlay this is not actively broken but its still better to be consistent I think.
No behaviour change for published charts as the overlay wins anyway.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker