Fix flaky pause/resume queue tests#198
Merged
Merged
Conversation
The pause/resume tests polled getQueue() after mutating the queue, but those reads are eventually consistent and could still report the old state well beyond the backoff window, causing random failures. Return the Queue from CloudTasksApi::pause()/resume() and assert on the RPC response, which carries the new state synchronously. This drops the polling helpers and makes the tests deterministic and independent of each other. Also remove the now-stale PHPStan ignore for the QueuePaused/ QueueResumed events, which exist in the supported Laravel versions.
These events only exist in newer Laravel versions, and the code guards them with class_exists(). The ignore is required on versions where the classes are absent, but is unmatched where they exist, so set reportUnmatchedIgnoredErrors: false instead of removing it.
marickvantuil
force-pushed
the
fix/pause-resume-flaky-test
branch
from
4642f32 to
e4cb5dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pause/resume tests polled getQueue() after mutating the queue, but those reads are eventually consistent and could still report the old state well beyond the backoff window, causing random failures.
Return the Queue from CloudTasksApi::pause()/resume() and assert on the RPC response, which carries the new state synchronously. This drops the polling helpers and makes the tests deterministic and independent of each other.
Also remove the now-stale PHPStan ignore for the QueuePaused/ QueueResumed events, which exist in the supported Laravel versions.