Skip to content

Fix renovate author check and add manual retry to autogen-docs notify#1006

Merged
danbarr merged 3 commits into
mainfrom
fix-autogen-docs-notify-author-check
Jul 1, 2026
Merged

Fix renovate author check and add manual retry to autogen-docs notify#1006
danbarr merged 3 commits into
mainfrom
fix-autogen-docs-notify-author-check

Conversation

@danbarr

@danbarr danbarr commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Two fixes to the `autogen-docs-notify` workflow introduced in #1002:

  • gh pr view --json author returns the login as app/renovate, not renovate[bot], so the author check in the "Resolve PR" step always failed and the notify job silently skipped every PR.
  • The workflow_run trigger replaced the old draft-flip approach, which also removed the ability to manually re-trigger a missed notification.

Adds a workflow_dispatch input with a pr_number field as a direct retry path (label/author guard skipped for human-initiated runs).

Type of change

  • Bug fix (typo, broken link, etc.)

Related issues/PRs

Follows #1002.

Submitter checklist

Content and formatting

  • I have reviewed the content for technical accuracy
  • I have reviewed the content for spelling, grammar, and style

danbarr and others added 2 commits July 1, 2026 16:11
gh pr view --json author returns login as app/renovate, not
renovate[bot], so the string comparison always failed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
workflow_run replaces the old draft-flip escape hatch, so there is no
longer a way to manually re-trigger the notify for a missed PR.
Add workflow_dispatch with a pr_number input as a direct retry path.
The label/author guard is skipped for workflow_dispatch since the
caller is a human explicitly choosing a PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 1, 2026 20:13
@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-website Ready Ready Preview, Comment Jul 1, 2026 8:18pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes the autogen-docs-notify GitHub Actions workflow so it (1) correctly detects Renovate-authored PRs after switching to workflow_run, and (2) supports manual retries via workflow_dispatch with a pr_number input.

Changes:

  • Add a workflow_dispatch trigger with a required pr_number input to allow manual notification retries.
  • Update the notify job gating and PR resolution logic to support both workflow_run and manual dispatch runs.
  • Fix the Renovate author check to match the login format returned by gh pr view --json author.

Comment thread .github/workflows/autogen-docs-notify.yml
Comment thread .github/workflows/autogen-docs-notify.yml Outdated
Gate workflow_dispatch to refs/heads/main so manual retries always
run from the trusted default-branch workflow definition.

Accept both app/renovate and renovate[bot] as valid author logins to
handle both GitHub App and bot account forms of Renovate.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@danbarr danbarr merged commit b5b7145 into main Jul 1, 2026
3 checks passed
@danbarr danbarr deleted the fix-autogen-docs-notify-author-check branch July 1, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants