Conversation
Define the cause-free successful-response decoder boundary while preserving body-read, server, authentication, transport, and cancellation causes. Relates to #1694 Co-authored-by: Codex <codex@openai.com> Signed-off-by: Samuele Verzi <samu@stacklok.com>
samuv
force-pushed
the
plan/sdk-malformed-success-causes
branch
from
September 18, 2026 09:11
b838fe8 to
b6e0582
Compare
samuv
added this pull request to stack #1701
September 18, 2026 09:51
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProtocolError.cause.Development stage
Contract linkage
docs/adr/0348-typescript-sdk-malformed-success-decoding.mdgh stacklayer without waiting for this PR to merge; neither PR is authorized to merge heredocs/acceptance/sdk-malformed-success-decoding.mdInterface conformance
causeproperty.Issue relationship
Relates to #1694
Type of change
Test plan
Baseline checks
task lint)task test)go run ./cmd/mecademo)CGO_ENABLED=0 task docs)task site:build)task api:check)task api:update+engine/CHANGELOG.mdtask ac-trace-strict)/panel-reviewtask docsrequiresCGO_ENABLED=0in this worktree because the host Xcode/macOS SDK linker rejects its ownarm64e.x1-*architecture set; all documentation generation and strict link checks pass with CGO disabled.Changes
docs/acceptance/sdk-malformed-success-decoding.mddocs/adr/0348-typescript-sdk-malformed-success-decoding.mddocs/acceptance/README.md,docs/adr/README.mdUser-facing change
None in this PR; it defines the contract for the stacked implementation.
Special notes for reviewers
The decoder boundary begins only after a unary body has been acquired.
Response.json()combines body acquisition with JSON parsing, so the implementation must splitresponse.text()fromJSON.parse()to avoid stripping causes from body-read/network failures.