fix(studio): composer streaming-stuck bug + toolbar/search/projects polish - #1732
Closed
jtenniswood wants to merge 2 commits into
Closed
jtenniswood wants to merge 2 commits into
jtenniswood wants to merge 2 commits into
Conversation
…nd settles The durable session watch (ADR 0250) speculatively sets status="streaming" the instant it mounts, before it has replayed anything. It mounts whenever the inventory poll reports a session as running/awaiting and this tab isn't driving it — but that guard only checks the instantaneous drivingRef, which this tab's own send already clears once its stream settles. A stale "running" row from the next poll tick (an ordinary staleness window between the daemon recording completion and Studio's next fetch) then satisfies both conditions, mounts the watch, and leaves the composer stuck showing "Queue a message..." indefinitely — reproduced live against a real daemon and confirmed only a reload cleared it. Track whether the watch's own replay has seen an unterminated run; at the replay→live boundary, correct status back to idle when nothing is parked and no run is genuinely in progress, instead of leaving the mount-time guess in place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ct rows - The Mode/Tools/Safety/Model pills sit at rest with no border or fill (only on hover and while their own menu is open), and the Mode pill's colour dot is gone. - The starter-prompt chips wrap at 768px, matching the composer's own width, instead of a narrower 576px column. - --nav-search-border was defined too close in lightness to --nav-background in every palette (~2.9:1 contrast), so the top-nav search box's outline was barely visible; brightened it to match each palette's already-legible --nav-icon. - A project row in the Labs mock Projects list now reads bold/foreground so it stands out from the muted chats filed under it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
closing the exploration in this repo |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A short pass of live UI polish on Studio's chat workspace, found and verified by driving the app directly (real dev server, real daemon) rather than by inspecting code in isolation.
completed. Root cause: the durable session watch speculatively setsstatus = "streaming"at mount, and a stale "running" row from the inventory poll — landing after this tab's own send has already settled — can re-arm it with nothing left to ever correct it. Reproduced live against a real daemon, then pinned with a new deterministic regression test (use-agent-chat.watch-race.test.ts) that fails on the old code and passes on the fix.--nav-search-borderwas defined too close in lightness to--nav-backgroundin every palette (~2.9:1 contrast), so its outline was barely visible; brightened to match each palette's already-legible--nav-icon.Test plan
npx vitest run src/features/agent src/app/workspace/_components/chat-input src/app/workspace/chat/_components/chat-workspace src/app/workspace/chat/_components/session-sidebar— 89 files / 809 tests passednpx biome checkon every changed file — cleannpx tsc --noEmit— cleanBase branch
Stacked on
feat/webui(#1607), notmain— this branch is a checkout of that PR's tip plus these two commits, so the diff here is just this session's work.🤖 Generated with Claude Code