Security: Sensitive Header Names Not Validated for Env Var Safety#5723
Open
tomaioo wants to merge 1 commit into
Open
Security: Sensitive Header Names Not Validated for Env Var Safety#5723tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
In `GenerateOpenTelemetryEnvVarsFromRef`, the `normalizeHeaderEnvVarName` function converts header names to environment variable names by only replacing dashes with underscores and uppercasing. However, it does not validate that the resulting string is a valid environment variable name (e.g., it could start with a digit, contain invalid characters, or be empty). This could lead to invalid environment variable configurations in pods. More critically, if a malicious user can control header names through the CRD, they could potentially craft header names that cause unexpected behavior or conflicts with system environment variables. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
tomaioo
requested review from
ChrisJBurns,
JAORMX,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Sensitive Header Names Not Validated for Env Var Safety
Problem
Severity:
Medium| File:cmd/thv-operator/pkg/controllerutil/telemetry.go:L52In
GenerateOpenTelemetryEnvVarsFromRef, thenormalizeHeaderEnvVarNamefunction converts header names to environment variable names by only replacing dashes with underscores and uppercasing. However, it does not validate that the resulting string is a valid environment variable name (e.g., it could start with a digit, contain invalid characters, or be empty). This could lead to invalid environment variable configurations in pods. More critically, if a malicious user can control header names through the CRD, they could potentially craft header names that cause unexpected behavior or conflicts with system environment variables.Solution
Add validation to
normalizeHeaderEnvVarNameto ensure the resulting environment variable name is valid: must start with a letter or underscore, contain only alphanumeric characters and underscores, and not exceed standard env var length limits. Also consider adding a prefix to avoid collisions with system environment variables.Changes
cmd/thv-operator/pkg/controllerutil/telemetry.go(modified)