Skip to content

Enable backwards-compatibility with Eigen < 5 #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrjohns merged 2 commits into from
Jul 1, 2026
+8 −5
Merged

Enable backwards-compatibility with Eigen < 5 #3338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d2e8d
Enable backwards-compatibility Eigen < 5
andrjohns Jun 30, 2026
ad5ec5c
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stan/math/fwd/fun/Eigen_NumTraits.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ struct ScalarBinaryOpTraits<std::complex<stan::math::fvar<T>>,

namespace internal {

#if EIGEN_VERSION_AT_LEAST(5, 0, 0)
/**
* Partial specialization of Eigen's ternary evaluator for `.select()`
* expressions on matrices of `fvar<T>`, restoring the lazy (Eigen 3.x)
Expand Down Expand Up @@ -247,6 +248,7 @@ struct ternary_evaluator<
Arg1, Arg2, Arg3>;
using Base::Base;
};
#endif

} // namespace internal

Expand Down
9 changes: 4 additions & 5 deletions stan/math/prim/meta/lazy_select_evaluator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,10 @@ struct lazy_select_evaluator
& static_cast<int>(Arg3Flags)
& (StorageOrdersAgree ? Eigen::LinearAccessBit : 0))),
Flags = (Flags0 & ~Eigen::RowMajorBit) | (Arg1Flags & Eigen::RowMajorBit),
Alignment = Eigen::internal::plain_enum_min(
Eigen::internal::plain_enum_min(
Eigen::internal::evaluator<Arg1>::Alignment,
Eigen::internal::evaluator<Arg2>::Alignment),
Eigen::internal::evaluator<Arg3>::Alignment)
Alignment
= std::min({static_cast<int>(Eigen::internal::evaluator<Arg1>::Alignment),
static_cast<int>(Eigen::internal::evaluator<Arg2>::Alignment),
static_cast<int>(Eigen::internal::evaluator<Arg3>::Alignment)})
};

EIGEN_DEVICE_FUNC explicit lazy_select_evaluator(const XprType& xpr)
Expand Down
2 changes: 2 additions & 0 deletions stan/math/rev/core/Eigen_NumTraits.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ struct ScalarBinaryOpTraits<std::complex<stan::math::var>,

namespace internal {

#if EIGEN_VERSION_AT_LEAST(5, 0, 0)
/**
* Partial specialization of Eigen's ternary evaluator for `.select()`
* expressions on matrices of `var`, restoring the lazy (Eigen 3.x)
Expand Down Expand Up @@ -299,6 +300,7 @@ struct ternary_evaluator<
Arg1, Arg2, Arg3>;
using Base::Base;
};
#endif

/**
* Enable linear access of inputs when using read_vi_val_adj.
Expand Down