Conversation
Collaborator
|
Seems pretty good! I hadn't imagined we'd get into the runtime validation, but I guess it doesn't hurt much. And makes debugging easier than trying to debug it once it's running on the page. |
Contributor
Author
|
Yes, definitely easier to debug at a small cost. I think it is worth it for ergonomic APIs, then users can fallback to constructing it manually if they would like to. |
kdheepak
commented
Sep 20, 2026
kdheepak
commented
Sep 20, 2026
Contributor
Author
|
This PR should be ready to go now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #54 and the second part to #13
This PR adds an action generator helper for fetch and signal helpers. It also adds tests and a section in the README for this interface.