Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
sl-at-ibm
marked this pull request as ready for review
September 9, 2026 20:40
amorton
requested changes
Sep 20, 2026
amorton
left a comment
amorton
left a comment
Contributor
There was a problem hiding this comment.
-1 - the collection must have a vector to use hybrid. We are defining hybrid as vector + optional other legs.
2 tasks
Contributor
Author
ACK, makes sense. Thanks for taking the time to review this one. |
Contributor
|
closing per discussions above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Address #2577 under the assumption that symmetry is preferrable (between vector/ize-only and lexical-only paths for f.A.R.R.)
In other words, rather than better dressing the error mentioned in the issue (no vector/ize provided => illegal arg exception), it accepts a findAndRerank with the lexical part only in $hybrid, executes that leg of the retrieval, and submits those results to the reranker.
Note: this PR is kept intentionally clear of fixing the absence of "rerankOn" (these two errors are close to each other). This is to avoid overlapping with #2578 which deals with that issue. If that other ever gets merged, it might be a good idea to add a test to this one for the case with lexical-only and no rerankOn.
Which issue(s) this PR fixes:
Fixes #2577
Checklist