Repository navigation
BulkImageScrape: add configurable delay between image scrapes - #817
Open
officialasishkumar wants to merge 1 commit into
Open
officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
The plugin always slept a hardcoded 0.5 seconds before scraping each image, which is not enough for scrapers hitting rate-limited websites and cannot be changed without editing the plugin on disk. Add a ScrapeDelaySeconds NUMBER setting. When unset the previous 0.5 second delay is kept, 0 disables the delay, negative values are clamped to 0 and non-numeric/non-finite values fall back to the default with a warning. Document the setting in the README and bump the plugin version. Closes stashapp#736
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
ScrapeDelaySecondssetting to Bulk Image Scrape so users can slow down scraping for rate-limited sites (see #736).0disables the delay, negative values are clamped to 0, and non-numeric/NaN/inf values fall back to the default with a warning.Validation:
node validator/index.js --cipasses, the script compiles, and the parsing helper was exercised against None/empty/int/float/string/negative/NaN/inf/bool/list inputs.Closes #736