Repository navigation
Conversation
Contributor
Author
|
@jasonvarga I'm not sure if the same event should be used. We don't really need it because the cache will be invalidated on the |
edalzell
marked this pull request as ready for review
March 1, 2025 15:04
Contributor
# Conflicts: # lang/en/messages.php # resources/js/components/entries/PublishActions.vue # src/Contracts/Revisions/Revision.php # src/Providers/AppServiceProvider.php # src/Revisions/Revisable.php # src/Revisions/Revision.php # src/Revisions/RevisionRepository.php # tests/Revisions/RepositoryTest.php
Contributor
Author
|
@jasonvarga this is finally ready for you! |
edalzell
marked this pull request as draft
March 24, 2026 23:48
# Conflicts: # src/Http/Controllers/CP/Collections/EntryRevisionsController.php
edalzell
marked this pull request as ready for review
March 25, 2026 17:01
# Conflicts: # src/Providers/AppServiceProvider.php
jasonvarga
requested changes
Sep 2, 2026
jasonvarga
left a comment
Member
There was a problem hiding this comment.
Automated review findings (see inline comments for details).
Also blocking, not tied to a single line:
- The branch no longer merges cleanly against
6.x(mergeStateStatus: DIRTY). Conflicts insrc/Providers/AppServiceProvider.phpandtests/Revisions/RepositoryTest.php, andresources/js/components/entries/PublishActions.vueauto-merges into a duplicateemitskey (this branch hasemits: ['saving', 'saved', 'failed'], 6.x now hasemits: ['closed', 'saving', 'saved', 'failed']) — needs a manual resolve, not an accept-both merge. - No test exercises
HandleRevisionSchedule::handle()at all — nothing asserts an entry actually becomes published, that the working copy is removed, or that apublish-action revision is recorded. A single test dispatching the job would have caught theTypeErrorand the missingpublished(true)call flagged inline below. tests/Feature/Revisions/__fixtures__/123/{1553546421,1553546422,working}.yamlare added but nothing in the suite references them (the only__fixtures__path used istests/Revisions/__fixtures__/). Dead files.- There's an open, unanswered question from @edalzell on whether reusing the
EntryScheduleReachedevent is correct here — its existing meaning is "an entry's own date has arrived," which isn't quite what's happening on a scheduled revision publish. Would like a maintainer call on this before merge.
…visions # Conflicts: # src/Providers/AppServiceProvider.php # tests/Revisions/RepositoryTest.php
Query the revisions store directly for revisions due (publish_at <= now) instead of scanning every entry, so missed scheduler ticks catch up. Publishing a scheduled revision now sets the entry published, records a publish revision, clears publish_at so it is not re-applied, and removes the working copy unless it changed since scheduling.
Contributor
Author
|
Merged 6.x and addressed the review:
Still open for a maintainer call: whether reusing |
…visions # Conflicts: # tests/Feature/Entries/EntryRevisionsTest.php
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We have clients who have future campaigns, and they'd like to get all the content set up ahead of time so they can review and adjust. They use revisions.
So they'd like to schedule a revision to be published at a specific date/time.
Closes statamic/ideas#642.
Companion eloquent-driver PR: statamic/eloquent-driver#613