[6.x] Multisite - Fix localization switch sending the browser to /entries/null - #15230
Open
jaygeorge wants to merge 1 commit into
Open
[6.x] Multisite - Fix localization switch sending the browser to /entries/null#15230jaygeorge wants to merge 1 commit into
jaygeorge wants to merge 1 commit into
Conversation
Missing localizations have a null edit URL. Wait until after a successful load before updating history so we don't stringify null into the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Creating a new localization rewrites the browser URL to
/entries/null.Even though the page will continue to save, the URL does not change which means a refresh breaks the page.
What this PR Does
Wait until after a successful load before updating history so we don't stringify
nullinto the path.How to Reproduce
/entries/nulland stays broken even after the localization is created; refreshing fails