Repository navigation
[6.x] Stop deep-watching publish container meta - #15713
Merged
Merged
Conversation
Contributor
|
Member
|
Cool solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to #15688, Replicator sets now remember whether they are collapsed. A small side effect: on big entries every expand / collapse click got sluggish (around 140 ms on one of ours, up from basically just 1-2ms).
Not Erins fault! :D The publish container has been re-checking all the meta in the entry whenever anything changed. #15688 just started ringing that doorbell a lot more often.
The container now only reacts to actual meta updates instead of rescanning everything. Toggles are instant again, and other meta changes (adding sets, picking assets …) get a little faster too.