Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15628.
A navigation blueprint can define the
urlfield as a link field. Picking an entry there stores a reference such asentry::4af6f16d-…as the page's url. The CP keeps the field config (ensureField('url', [])doesn't override it).Page::url()returned that stored value as it was, so{{ url }}in anavtag renderedhref="entry::4af6f16d-…". Link fields with any other handle were already resolved by the Link fieldtype's augmentation.Changes
Page::url(),urlWithoutRedirect()andabsoluteUrl()resolve link references (anythingLink::types()knows, soentry::andasset::and addon link types) throughResolveRedirect, the same way the Link fieldtype does.uri()andabsoluteUrlWithoutRedirect()go through those methods. Entries are localized to the current site unless the nav can select across sites; an entry on another site gets its absolute url, as for entry pages ([6.x] Fix nav entry links across sites losing their domain #15239).nullinstead of the raw reference.::go through the resolver.NavigationPagesControllernow reads it from a newPage::customUrl(), which pairs with the existinghasCustomUrl().Tests
PageTest: a page whose url isentry::123resolves to the entry's url in all the url methods, and a link to a missing entry has no url.EditNavigationPageTest: the page editor gets the storedentry::123.