Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builder::paginate()callsgetCountForPagination()for the total and thenget()for the page. On the local driver both end up inComb\Query::getSearchResults(), which callsindex->lookup()each time, so{{ search:results paginate="10" }}(orSearch::index('default')->search('foo')->paginate(10)) decodes the index file and runs the full Comb scan twice per request.Fix memoizes the lookup per query builder instance, keyed by the query string, in
Comb\Queryonly. Tests:paginate()callslookup()once; changing the query viaquery()looks up again.Benchmark (synthetic local index,
withoutData(), median ms over 5 runs, PHP 8.5, M-series Mac; script: https://gist.github.com/edalzell/4d75387d098abbebf63f00c523db8d18):commonrarewordcommonrarewordcommonrarewordThe 1,000/
commonget()row is the first measurement of the run (opcache cold); every other row showsget()unchanged.The same double call affects
Search\QueryBuilder::getBaseItems()for every driver (hydration runs twice, Algolia makes two API calls); left for a follow-up since #13217 is changing that area.