Repository navigation
[6.x] Antlers HTML instrumentation - #15728
Open
JohnathonKoster wants to merge 21 commits into
Open
JohnathonKoster wants to merge 21 commits into
JohnathonKoster wants to merge 21 commits into
Conversation
…rumentation # Conflicts: # src/View/Antlers/Language/Parser/Concerns/CompilesBladeComponents.php
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds opt-in instrumentation to Antlers. When enabled, comments are injected into the rendered HTML that point back to the template expression that produced each bit of output
What the output looks like
Given this template:
you get this (payloads trimmed):
The start marker payload is base64 JSON:
{ "type": "single", "engine": "antlers", "expression": "title", "line": 2, "start": 29, "end": 40, "context": "element-content", "element": "h1", "view": "page.antlers.html", "id": 1 }Docs/API
Docs and API are still a work in progress; most of the API surface area has been marked
internalto discourage third-party use (for now) and to allow freedom to change things without worrying about backwards compatibility, and also not sit on this feature set until its "perfect" 🙂