Repository navigation
fix(scripts): read source URL status from curl - #44
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_source_urlstook the HTTP status from the last line that starts withHTTP/and compared it with[[ ... -ge 400 ]]. bash evaluates that operand as arithmetic, and an array subscript in it runs a command. The server of a source, a host it redirects to, or anyone on the path of anhttp://source could answer the HEAD request with a line such asHTTP/1.1: BASH_VERSINFO[$(id>file)]and runidinprepare, or on the machine that runsupdate-pkg.shwithout--prepare.curl now reports the status and the
Content-Typeof the last response through-w, and a status that is not three digits fails the check.text/htmlmatches in any letter case.bats tests/ --recursive: 431 pass.