Repository navigation
fix(strategy): take scrape captures without sed - #55
Merged
Merged
Conversation
validate-pkg.sh compiles the pattern with bash as the strategy does.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpage-scrapetook the capture group withsed -E "s/$pattern/\1/", so a pattern with a/, a path on a download page for one, ended thescommand and failed every run, whilevalidate-pkg.shreported it valid.capture_matchesinscripts/lib.shnow finds the matches withgrep -oEand takes the group with bash[[ =~ ]]andBASH_REMATCH[1]. No sed runs the pattern any more.validate-pkg.shchecks the pattern withere_valid, which compiles it with bash: bash refuses some patterns thatgrep -Etakes,(?:...)and*xamong them.docs/WORKFLOW.md3.13 describes the change, and its example/download/v([0-9.]+)/works now.